Skip to content

[CAL][3] - Implement GetChainFeeComponents #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

[CAL][3] - Implement GetChainFeeComponents #985

merged 2 commits into from
Jun 9, 2025

Conversation

@ogtownsend
Copy link
Contributor

@ogtownsend ogtownsend commented Jun 5, 2025 •
edited
Loading

core ref: aad88a584c81e0be68f68927d5ab041fc65ca646

  • Implement GetChainFeeComponents() functions for Chain Access Layer in legacy accessor
  • For more context, see NONEVM-1865

Stack:

  1. [CAL][1] - Add initial CAL scaffolding to CCIPReader with legacy accessor #978
  2. [CAL][2] - Implement Metadata() and GetContractAddress() #980
  3. ➡ [CAL][3] - Implement GetChainFeeComponents #985
  4. [CAL][4] - Implement MsgsBetweenSeqNums() function in accessor #987
  5. [CAL][5] - implement LatestMsgSeqNum #988
  6. [CAL][6] - move SourceChainConfig to chainaccessor types #989
  7. [CAL][7] - implement GetExpectedNextSequenceNumber #990
  8. [CAL][8] - Some minor cleanup and renaming #999
  9. [CAL][9] - Implement CommitReportsGTETimestamp, GetTokenPriceUSD, and GetLatestPriceSeqNr #1000
  10. [CAL][10] - Implement Nonces and GetChainFeePriceUpdate #1014
  11. [CAL][11] - Implement ExecutedMessages for chain accessor #1017

@ogtownsend ogtownsend requested a review from winder June 5, 2025 17:03
@ogtownsend ogtownsend changed the base branch from main to ogt/cal-2-implement-metadata June 5, 2025 17:03
This was referenced Jun 5, 2025
Merged
Merged
@ogtownsend ogtownsend force-pushed the ogt/cal-2-implement-metadata branch from 45af24c to c5cd09d Compare June 5, 2025 17:05
@ogtownsend ogtownsend marked this pull request as ready for review June 5, 2025 17:26
@ogtownsend ogtownsend requested review from a team, 0xAustinWang, 0xnogo, AmrMohamedRezk, asoliman92, makramkd and matYang and removed request for a team June 5, 2025 17:26
@ogtownsend ogtownsend force-pushed the ogt/cal-2-implement-metadata branch from c5cd09d to f3793b2 Compare June 6, 2025 01:07
@ogtownsend ogtownsend force-pushed the ogt/cal-3-implement-get-chain-fee-components branch 2 times, most recently from 7f0c330 to 85b4921 Compare June 6, 2025 04:37
This was referenced Jun 6, 2025
Merged
Merged
Merged
Merged
@ogtownsend ogtownsend force-pushed the ogt/cal-2-implement-metadata branch from f3793b2 to f1c5807 Compare June 9, 2025 14:34
@ogtownsend ogtownsend force-pushed the ogt/cal-3-implement-get-chain-fee-components branch from 85b4921 to d599a96 Compare June 9, 2025 14:34
@ogtownsend ogtownsend mentioned this pull request Jun 9, 2025
Closed
winder
winder reviewed Jun 9, 2025
View reviewed changes
pkg/types/ccipocr3/chain_accessor.go
GetDestChainFeeComponents(
ctx context.Context,
) (types.ChainFeeComponents, error)
GetChainFeeComponents(ctx context.Context) (ChainFeeComponents, error)
Copy link
Contributor

@winder winder Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

winder
winder previously approved these changes Jun 9, 2025
View reviewed changes
@ogtownsend ogtownsend force-pushed the ogt/cal-2-implement-metadata branch from f1c5807 to 29363fc Compare June 9, 2025 20:14
@ogtownsend ogtownsend force-pushed the ogt/cal-3-implement-get-chain-fee-components branch 2 times, most recently from 57761d2 to c2b4160 Compare June 9, 2025 20:21
@ogtownsend ogtownsend force-pushed the ogt/cal-2-implement-metadata branch from 29363fc to c9aa793 Compare June 9, 2025 20:23
@ogtownsend ogtownsend force-pushed the ogt/cal-3-implement-get-chain-fee-components branch from c2b4160 to 9e3d292 Compare June 9, 2025 20:26
@ogtownsend ogtownsend changed the base branch from ogt/cal-2-implement-metadata to main June 9, 2025 21:09
@ogtownsend ogtownsend dismissed winder’s stale review June 9, 2025 21:09

The base branch was changed.

@ogtownsend ogtownsend force-pushed the ogt/cal-3-implement-get-chain-fee-components branch from 9e3d292 to 8f950d6 Compare June 9, 2025 21:22
winder
winder previously approved these changes Jun 9, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Metric ogt/cal-3-implement-get-chain-fee-components main
Coverage 72.1% 71.7%

@winder winder self-requested a review June 9, 2025 22:27
@ogtownsend ogtownsend added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit 3a7c5b2 Jun 9, 2025
46 of 62 checks passed
This was referenced Jun 10, 2025
Merged
Merged
Merged
Merged
@ogtownsend ogtownsend deleted the ogt/cal-3-implement-get-chain-fee-components branch June 17, 2025 19:58
@ogtownsend ogtownsend mentioned this pull request Jun 18, 2025
Merged
This was referenced Jun 25, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winder winder winder approved these changes

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@AmrMohamedRezk AmrMohamedRezk Awaiting requested review from AmrMohamedRezk AmrMohamedRezk is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ogtownsend @winder